⚗️ Add canvas recording init configuration - #4947
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 1bc1fbf | Docs | Datadog PR Page | Give us feedback! |
Bundles Sizes Evolution
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 066a0c36d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4845699db1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e132ae585
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1e132ae to
1bc1fbf
Compare
Motivation
Prepare the Browser SDK configuration surface for Session Replay canvas recording while keeping the capability behind an experimental feature flag. Using an object for the canvas option leaves room for future controls such as maximum image size or compression type without adding more top-level initialization parameters.
Design references:
Changes
enableSessionReplayCanvasRecordingRUM initialization object.maxFramesPerSecondoption, defaulting to 1 FPS with a supported range from 0 to 5 FPS. Setting it to0disables canvas frame recording.session_replay_record_canvasexperimental feature flag before the configuration is effective.numberfield to the js-core configuration schema, with optional inclusiveminandmaxbounds.Test instructions
yarn test:unit --spec packages/js-core/src/entries/configuration.spec.ts --spec packages/browser-rum-core/src/domain/configuration/configuration.spec.tsyarn typecheckyarn api:checkChecklist